Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Alerts | Filter for devices #54672

Closed
andyl-ioki opened this issue Aug 14, 2023 · 9 comments
Closed

Transaction Alerts | Filter for devices #54672

andyl-ioki opened this issue Aug 14, 2023 · 9 comments

Comments

@andyl-ioki
Copy link

Problem Statement

Current Setup

We have a React Native app which is used by many different devices. Therefore the performance differs very widely for each device.

As we roll out new versions of our App we want to monitor, if the performance improves, remains constant or (hopefully not) degrades.
So what we did is, filtering transactions manually for specific app versions and compare it with older versions.
Or we created alerts that have a specific threshold for each version of our App.

Disadvantages right now

There are several downsides of this approach:

  • new devices (types) modify the overall performance (to the better or the worse)
  • a specific device group may first switch to a new version
    • e.g.: only bad performing devices may switch first to a new version, which would raise the alerts in the beginning, even though that these "bad" devices, behave the same as on the old version
  • we receive too many false positives with this approach

What we can do manually

Get to the transaction, filter for a specific device (e.g. device:SM-G398FN) and check the average duration of it.
But this involves "too" much manual work.

Solution Brainstorm

Implement the possibility to filter for specific devices in a transaction alert.
With this feature we can check if our app changed the performance for a specific device group (to the better or worse) because of new features/refactorings/bugfixes.


Also thanks for providing/maintaining/extending this platform 👍
Helps us a lot :)

Product Area

Alerts

@getsantry
Copy link
Contributor

getsantry bot commented Aug 14, 2023

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Aug 14, 2023

Routing to @getsentry/product-owners-alerts for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 Aug 14, 2023
@lobsterkatie
Copy link
Member

Hi, @andyl-ioki. Does it not work for you to filter on device in your alert rule?

image

@andyl-ioki
Copy link
Author

Good day @lobsterkatie!

Thanks for your reply.

Unfortunately this does not work. I tried it already and it states:

No items found

Also the docs state the following for transactions:

... the following properties are available: release, transaction, transaction.status, transaction.op, http.method, http.status_code, os.name, browser.name and geo.country_code.

I don't know why there is this difference for error and transactions (we are using transactions), but it would be really cool filter in transactions (at least for us) for specific devices.
The best and future proof would be allowing to filter for all tags, but maybe there are reasons against it :)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Aug 15, 2023
@lobsterkatie
Copy link
Member

lobsterkatie commented Aug 15, 2023

Hmmm - I'm surprised that didn't work for you. Despite what the docs say (we recently changed how we implement transaction alerts, and the docs need to be updated), one of my colleagues who's worked on the feature just assured me that now you can indeed filter on device.name.

I just tried it, and when I type device it pops up with possible completions:

image

And when I click on name, it then pops up with values it's seen for that tag:

image

Does that not happen for you?

@andyl-ioki
Copy link
Author

When I enter device.name this shows up:
Screenshot 2023-08-16 at 08 12 07

(Maybe I am in a different testing group?)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Aug 16, 2023
@lobsterkatie
Copy link
Member

UPDATE: Just had a PM comment on my slack thread with the engineer, to say that we haven't released this fully, but should be rolling it out to everyone in the coming weeks.

@andyl-ioki
Copy link
Author

Thanks for letting me know. :)
It will improve our alerts a looooot 🕺 🎉

@andyl-ioki
Copy link
Author

I just tried it and it is working now 🎉
Thanks a lot 👍 @lobsterkatie

Closing it. :)

@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

3 participants