Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: UI when there are few/no results #55683

Closed
Tracked by #54094
matejminar opened this issue Sep 5, 2023 · 1 comment
Closed
Tracked by #54094

Design: UI when there are few/no results #55683

matejminar opened this issue Sep 5, 2023 · 1 comment
Assignees

Comments

@matejminar
Copy link
Member

matejminar commented Sep 5, 2023

Problem: We have certain product workflows today where customers can "drill down" into their transaction data to look for specific samples by using a search function:

Our biases try to offer a good baseline of samples out of the box, but we cannot guarantee them for very specific queries.

Proposed solution:
When customers are presented with no or few samples after a search within Discover and the Tx Summary page, give them an option to temporarily collect samples that match the given criteria.

For the POC the following is sufficient:

  • the user can easily create a new investigation bias
  • the user has a way to know whether the collection is in progress of not
  • the user has a way to get notified about the results (when we've collected enough samples or how many we collected by the time the 1h time interval expired).

Other Notes:

  • The bias will only support sampling for transactions, not full tracing
  • In case the query cannot be transformed into a rule (relay condition), we need to handle this in the UI
    • We can display which tag is not supported and suggest the user to drop it
  • once the collection starts, it stops either once it collects 100 samples or for maximum 1h (whichever comes first)
    • The number of samples is currently hardcoded to 100, this can change in the future
  • While the bias is active, we need to show a visual indicator that the collection of sampling is in progress
  • Customers can have multiple investigation biases concurrently (there is a high abuse limit)
  • For now, there temporary biases cannot be deleted/deactivated (This would be problematic because a new rule that matches the exact conditions of a pre-existing rule, so it can get messy).
  • We want to notify users once we have collected enough samples/the collection has stopped
    • The user should still specify who should be notified about updates (for now just the user who created it)
    • Even if we haven't collected the 100 samples, we should inform them about how many samples were indeed collected
  • Performance issues are another starting point Example 1 and Example 2, but those we should likely tackle with automated biases and not in scope of the POC.
@matejminar matejminar changed the title Show button in UI when there are few/no results Button in UI when there are few/no results Sep 5, 2023
@ale-cota ale-cota changed the title Button in UI when there are few/no results Design: UI when there are few/no results Sep 11, 2023
@Jesse-Box
Copy link
Contributor

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants