Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fields support in Relay #58504

Closed
Tracked by #58503
iambriccardo opened this issue Oct 20, 2023 · 4 comments · Fixed by getsentry/relay#2640
Closed
Tracked by #58503

Adding fields support in Relay #58504

iambriccardo opened this issue Oct 20, 2023 · 4 comments · Fixed by getsentry/relay#2640
Assignees
@iambriccardo

Comments

@iambriccardo
Copy link
Member

No description provided.

This was referenced Oct 20, 2023
Closed
Merged
@iambriccardo
Copy link
Member Author

The Relay PR lacks support for the following fields:

  • device.locale
  • device.screen_height_pixels
  • device.screen_width_pixels
  • device.uuid

@iambriccardo
Copy link
Member Author

Some work is being conducted to make sure that those fields will be supported.

@iambriccardo
Copy link
Member Author

sentry/src/sentry/data/samples/android.json

Line 21 in a49fd98

"screen_height_pixels": 1136,
the fields that are missing in the typed Relay struct, actually are sent from SDKs, thus they would need to be added into the struct.

@iambriccardo iambriccardo self-assigned this Oct 20, 2023
@iambriccardo
Copy link
Member Author

The PR has been updated with full support of the new fields.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iambriccardo iambriccardo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(on-demand): Extend support fields in the event getter getsentry/relay
1 participant
@iambriccardo