Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay Details] Seeking to the first segment does not work #68437

Closed
Tracked by #63255
billyvg opened this issue Apr 8, 2024 · 2 comments
Closed
Tracked by #63255

[Replay Details] Seeking to the first segment does not work #68437

billyvg opened this issue Apr 8, 2024 · 2 comments

Comments

@billyvg
Copy link
Member

billyvg commented Apr 8, 2024

Example Replay

The first segment is portrait, the 2nd is landscape. Let it play until it changes to landscape, then try to seek somewhere < 5 seconds, notice that the it remains in landscape. Seeking to :00 will rotate it back to portrait.

@michellewzhang
Copy link
Member

i tracked it down to findVideoSegmentIndex in utils.tsx returning the wrong segment index (it was returning 1 instead of 0 which is why the wrong segment was loaded when you seek), so i console logged trackList to see what was going on.

it looks like the first 2 + last 2 attachments have the same exact timestamp, which is why it was getting confused:

image

so i don't think it's the code, but rather something weird happened with the attachment timestamps -- seeking works normally with other replays with proper timestamps:

image

@billyvg
Copy link
Member Author

billyvg commented Apr 9, 2024

@michellewzhang good catch, I'm going to guess @romtsn was testing something and we got bad data. Don't think we need the UI to handle this type of bad data.

@billyvg billyvg closed this as completed Apr 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants