Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile replay tap events - shows multiple at the same time #72959

Closed
vaind opened this issue Jun 18, 2024 · 5 comments · Fixed by getsentry/rrweb#209
Closed

Mobile replay tap events - shows multiple at the same time #72959

vaind opened this issue Jun 18, 2024 · 5 comments · Fixed by getsentry/rrweb#209
Assignees
@michellewzhang
Labels
Product Area: Replays

Comments

@vaind
Copy link
Contributor

vaind commented Jun 18, 2024

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

assuming a replay with multiple tap events

  1. click on the last event
  2. click on the previous one
  3. etc

Expected Result

only the currently selected tap is rendered (as before)

Actual Result

all taps stay rendered

image

Product Area

Replays

Link

https://sentry-sdks.sentry.io/replays/698dbb072c734a76bc78cbd2bfaed07c/?project=5428561&query=&referrer=%2Freplays%2F&statsPeriod=7d&yAxis=count%28%29

DSN

No response

Version

No response
@getsantry
Copy link
Contributor

getsantry bot commented Jun 18, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 3 Jun 18, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Jun 19, 2024

Routing to @getsentry/product-owners-replays for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Jun 19, 2024
@michellewzhang
Copy link
Member

trim.9C2956F2-6E75-406F-88FC-715B11191554.MOV

i'm seeing this, not what's in the screenshot

@vaind
Copy link
Contributor Author

vaind commented Jun 20, 2024 •
edited
Loading

Does this help reproducing the issue?

Screen.Recording.2024-06-20.at.19.26.17.mov

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jun 20, 2024
@michellewzhang
Copy link
Member

ah sorry, missed the repro steps, i'll look into it

@michellewzhang michellewzhang self-assigned this Jun 20, 2024
@michellewzhang michellewzhang mentioned this issue Jun 20, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellewzhang michellewzhang

Labels
Product Area: Replays
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rrweb): clean up pointer tap circles when seeking by breadcrumb getsentry/rrweb
4 participants
@bruno-garcia @vaind @dalnoki @michellewzhang