Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash on Health Check glob patterns #81028

Open
frejete-equinix opened this issue Nov 20, 2024 · 2 comments · May be fixed by #81117
Open

Trailing slash on Health Check glob patterns #81028

frejete-equinix opened this issue Nov 20, 2024 · 2 comments · May be fixed by #81117

Comments

@frejete-equinix
Copy link

Problem Statement

The current list of glob patterns for ignoring health check requests do not match URLs with trailing slashes, i.e. https://mycoolapp.io/ping/ will not be ignored.

I work a lot with Django and the default behavior is to require trailing slashes on URL. Missing the slash will auto-redirect to the same URL with the trailing slash and disabling that option in the settings will result in 404s.

Solution Brainstorm

Could we update the default patterns to also match requests like */ping/ and */health/, etc.?

Product Area

Ingestion and Filtering

@getsantry
Copy link
Contributor

getsantry bot commented Nov 20, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Nov 20, 2024

Routing to @getsentry/product-owners-ingestion-and-filtering for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants