-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing slash on Health Check glob patterns #81028
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-ingestion-and-filtering for triage ⏲️ |
I'll wait until the PR is merged to give my feedback. |
Thanks, this works like a charm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Problem Statement
The current list of glob patterns for ignoring health check requests do not match URLs with trailing slashes, i.e.
https://mycoolapp.io/ping/
will not be ignored.I work a lot with Django and the default behavior is to require trailing slashes on URL. Missing the slash will auto-redirect to the same URL with the trailing slash and disabling that option in the settings will result in 404s.
Solution Brainstorm
Could we update the default patterns to also match requests like
*/ping/
and*/health/
, etc.?Product Area
Ingestion and Filtering
The text was updated successfully, but these errors were encountered: