Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract and publish @spotlightjs/astro package #38

Closed
Tracked by #17
Lms24 opened this issue Nov 14, 2023 · 0 comments · Fixed by #40
Closed
Tracked by #17

Extract and publish @spotlightjs/astro package #38

Lms24 opened this issue Nov 14, 2023 · 0 comments · Fixed by #40
Assignees

Comments

@Lms24
Copy link
Member

Lms24 commented Nov 14, 2023

We want to extract the Astro integration from the website package and make it a proper Astro integration package.

For the package to work properly with the npx astro add command, we need to keep a few things in mind:

  • The integration factory function needs to be the default export of the package
  • keywords need to be set according to the integrations guide
  • Other fields mentioned in the guide should also be set
  • AFAICT, we technically don't need to transpile to JS and we should be good to simply publish the TS source files. (Astro will bundle the integrations in its build). Let's see if this actually works.

Note: We can also first simply extract the package and worry about the package.json, keywords, etc later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants