Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make separate method to set a callback on SourceBundleWriter #865

Open
szokeasaurusrex opened this issue Sep 2, 2024 · 0 comments
Open

Make separate method to set a callback on SourceBundleWriter #865

szokeasaurusrex opened this issue Sep 2, 2024 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

Basically, do what was suggested here:

@loewenheim I also had the idea that we could similarly add a with_filter function to add a filter callback on the SourceBundleWriter to be used with write_object, which would allow us to deprecate and eventually remove write_object_with_filter.

Originally posted by @szokeasaurusrex in #864 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szokeasaurusrex