Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: fix 50-prompt.sh #4214

Open
1 task done
TraceyC77 opened this issue Nov 1, 2024 · 0 comments · May be fixed by #4334
Open
1 task done

bash: fix 50-prompt.sh #4214

TraceyC77 opened this issue Nov 1, 2024 · 0 comments · May be fixed by #4334
Labels
Packaging Problem Building the package as-is fails ("FTBFS"), or other problem with the packaging of software Priority: Normal Normal priority

Comments

@TraceyC77
Copy link
Contributor

TraceyC77 commented Nov 1, 2024

Please confirm there isn't an existing open report for this package

  • I have searched through package problem reports

Name

bash

Version

5.2.37

Summary of the problem

The zsh check in 50-prompt.sh is broken. It should be removed since code for zsh is being moved to the zsh package in #3431

More information

The zsh check being broken caused "shopt" to be used, which zsh doesn't recognize
When zsh sourced this, it also sourced all of /etc/profile which sourced all bash scripts
This caused errors to be seen by users. That was reworked in #3431
The if logic should be removed from 50-prompt.sh since it is no longer coupled with zsh

@TraceyC77 TraceyC77 added Priority: Normal Normal priority Packaging Problem Building the package as-is fails ("FTBFS"), or other problem with the packaging of software labels Nov 1, 2024
@github-project-automation github-project-automation bot moved this to Triage in Solus Nov 1, 2024
@EbonJaeger EbonJaeger changed the title packagename: bash - fix 50-prompt.sh bash: fix 50-prompt.sh Nov 1, 2024
@TraceyC77 TraceyC77 linked a pull request Nov 12, 2024 that will close this issue
1 task
@TraceyC77 TraceyC77 linked a pull request Nov 12, 2024 that will close this issue
1 task
@malfisya malfisya moved this from Triage to In Progress in Solus Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Packaging Problem Building the package as-is fails ("FTBFS"), or other problem with the packaging of software Priority: Normal Normal priority
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant