Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httr -> httr2 #21

Closed
sckott opened this issue Jan 10, 2024 · 0 comments · Fixed by #48 or #49
Closed

httr -> httr2 #21

sckott opened this issue Jan 10, 2024 · 0 comments · Fixed by #48 or #49
Assignees
@sckott
Labels
low priority Not urgent or critical, implement whenever v2.0 Should be implemented in PROOF v2.0
Milestone
rcromwell v3.2.6

Comments

@sckott
Copy link
Member

sckott commented Jan 10, 2024

  • vcr on cran only has support for httr, not httr2. httr2 support is in the works but not ready quite yet.
  • this package uses vcr.
  • which means we need to use httr in this pkg for now

move to httr2 once vcr has support for it on github at least (& cran before this pkg goes to cran)

see also getwilds/proofr#3
@sckott sckott self-assigned this Jan 14, 2024
@sckott sckott added this to the v4 milestone Jan 31, 2024
@vortexing vortexing moved this to Todo in PROOF Maintenance Mar 21, 2024
@tefirman tefirman modified the milestones: v4, PROOF v2.0 Jul 30, 2024
@tefirman tefirman added low priority Not urgent or critical, implement whenever v2.0 Should be implemented in PROOF v2.0 labels Jul 30, 2024
@sckott sckott mentioned this issue Aug 13, 2024
Merged
@sckott sckott modified the milestones: PROOF v2.0, rcromwell v3.2.6 Aug 13, 2024
@tefirman tefirman mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sckott sckott

Labels
low priority Not urgent or critical, implement whenever v2.0 Should be implemented in PROOF v2.0
Projects
No open projects
PROOF Maintenance
Status: Todo
Milestone
rcromwell v3.2.6
Development

Successfully merging a pull request may close this issue.

Swap httr out for httr2 getwilds/rcromwell
rcromwell v3.3.0 Updates getwilds/rcromwell
2 participants
@sckott @tefirman