Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on mime_guess is too loose #1845

Closed
jonassmedegaard opened this issue May 2, 2022 · 3 comments
Closed

dependency on mime_guess is too loose #1845

jonassmedegaard opened this issue May 2, 2022 · 3 comments
Labels
done in pr Already done in a PR

Comments

@jonassmedegaard
Copy link

jonassmedegaard commented May 2, 2022

Cargo.conf declared a dependency on mime_guess 2.0 but src/cmd/serve.rs calls function .essence_str() which was introduced in v2.0.2.

@jonassmedegaard
Copy link
Author

Ahh, it is not really mime_guess but its pulling in mime which needs to be at least v0.3.15.

So the most loose declaration is to add a (tightened) dependency on mime, like this:

# For mimetype detection in serve mode
mime_guess = "2.0"
# For essence_strr() function
mime = "0.3.15"

@Keats
Copy link
Collaborator

Keats commented May 2, 2022

When is that an issue?

@jonassmedegaard
Copy link
Author

When building without following Cargo.lock - e.g. when building in a constrained environment where only a subset of the revisions released at crates.io is available.

Concretely I am working on packaging zola for official inclusion in Debian. There is still about 100 crates missing, including mime v0.3.16 (Debian has only mime v0.3.9 which fails to build complaining that function essence_str() is undefined.

@Keats Keats added the done in pr Already done in a PR label Jun 10, 2022
@Keats Keats closed this as completed in d22f579 Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done in pr Already done in a PR
Projects
None yet
Development

No branches or pull requests

2 participants