Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'onchange' event is triggered at the wrong time when searching #85

Closed
leray opened this issue Jan 6, 2013 · 1 comment
Closed

'onchange' event is triggered at the wrong time when searching #85

leray opened this issue Jan 6, 2013 · 1 comment
Assignees

Comments

@leray
Copy link

leray commented Jan 6, 2013

when searching for an option in native select 'onchange' event is triggered only when the final option is selected, but with selectBoxIt 'onchange' is triggered every time you press a key

searching for 'hello world' will call 11 onchange events instead of 1

@ghost ghost assigned gfranko Jan 7, 2013
@gfranko gfranko closed this as completed in 55da71a Jan 7, 2013
@gfranko
Copy link
Owner

gfranko commented Jan 7, 2013

Another great issue here. I agree with you that the default behavior was incorrect (selecting an option before a user clicked on an option or pressed the enter key before an option was "focused"). Now in SelectBoxIt v2.5.0, the default behavior makes sure that an option is only selected if a user clicks on an option or presses the enter key while an option is "focused". The old style of aggressively selecting an option is also still available via the new aggressiveChange option. Thanks again for your issue and please let me know if you find anything else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants