Parse locale from Accept-Language HTTP header #92
Conversation
| get test_path, params: {}, env: { 'HTTP_ACCEPT_LANGUAGE' => 'de-CH, en-US, fr' } | ||
| assert_equal 'fr', response.body |
There was a problem hiding this comment.
Attention: no partial matches, only exact ones.
There was a problem hiding this comment.
Should be OK for us, since we can control the request headers.
config/application.rb
Outdated
| @@ -32,5 +32,9 @@ class Application < Rails::Application | |||
| config.api_only = true | |||
|
|
|||
| config.time_zone = 'UTC' | |||
|
|
|||
| config.i18n.available_locales = [:de, :en, :fr, :it, :rm] | |||
There was a problem hiding this comment.
If I understand the code correctly, the option for swiss-german is missing. Could it be added?
There was a problem hiding this comment.
How? What's the appropriate HTTP_ACCEPT_LANGUAGE header for schweizerdeutsch?
There was a problem hiding this comment.
This site says it would be "de-ch". Using the ISO 639-1 up-to ISO 639-3 would be "gsw". Another possibility could be just "ch" to match the style of the others, but I'm really not familiar with how this is usually handled 😬
There was a problem hiding this comment.
de-CH is german in Switzerland. That's for sure not what you intend. In BCP47's RFCs I didn't find any mapping to ISO, so I think gsw is the correct one according to the IANA tag list: http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
Fixes #78
(no effect though, because we don't have any translated content yet)