Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spv-out] reverseBits and countOneBits unimplemented #1895

Closed
hasali19 opened this issue May 9, 2022 · 1 comment · Fixed by #1897
Closed

[spv-out] reverseBits and countOneBits unimplemented #1895

hasali19 opened this issue May 9, 2022 · 1 comment · Fixed by #1897
Labels
area: back-end Outputs of shader conversion good first issue Good for newcomers lang: SPIR-V Binary SPIR-V input and output
Milestone
WGSL Specificatio...

Comments

@hasali19
Copy link
Contributor

hasali19 commented May 9, 2022

I noticed that the reverseBits and countOneBits functions don't seem to be implemented for the SPIR-V backend, though they seem to be implemented for all the other backends. Is this just an oversight?
@teoxoy teoxoy added lang: SPIR-V Binary SPIR-V input and output area: back-end Outputs of shader conversion labels May 9, 2022
@teoxoy teoxoy added this to the WGSL Specification V1 milestone May 9, 2022
@teoxoy
Copy link
Member

teoxoy commented May 9, 2022

They have not yet been implemented. They should most likely get translated to OpBitReverse and OpBitCount respectively.

@teoxoy teoxoy added the good first issue Good for newcomers label May 9, 2022
@hasali19 hasali19 mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: back-end Outputs of shader conversion good first issue Good for newcomers lang: SPIR-V Binary SPIR-V input and output
Projects
None yet
Milestone
WGSL Specification V1
Development

Successfully merging a pull request may close this issue.

Implement reverseBits and countOneBits for SPIR-V hasali19/naga
2 participants
@hasali19 @teoxoy