Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache index constants in SPV-out #651

Closed
kvark opened this issue Apr 2, 2021 · 0 comments · Fixed by #652
Closed

Cache index constants in SPV-out #651

kvark opened this issue Apr 2, 2021 · 0 comments · Fixed by #652
Assignees
@kvark
Labels
area: back-end Outputs of shader conversion good first issue Good for newcomers kind: refactor Making existing function faster or nicer lang: SPIR-V Binary SPIR-V input and output

Comments

@kvark
Copy link
Member

kvark commented Apr 2, 2021

For any AccessIndex expression, we need a constant ID. It would be great to re-use these instead of generating new IDs on every access. See create_constant in "src/back/spv/writer.rs"
@kvark kvark added good first issue Good for newcomers kind: refactor Making existing function faster or nicer lang: SPIR-V Binary SPIR-V input and output area: back-end Outputs of shader conversion labels Apr 2, 2021
@kvark kvark self-assigned this Apr 2, 2021
@kvark kvark mentioned this issue Apr 2, 2021
Merged
@kvark kvark closed this as completed in #652 Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
area: back-end Outputs of shader conversion good first issue Good for newcomers kind: refactor Making existing function faster or nicer lang: SPIR-V Binary SPIR-V input and output
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flip Y axis in SPIR-V frontend and backend kvark/naga
1 participant
@kvark