glsl-out: Perform casts in int only math functions #1978
Merged
+84
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
force-pushed
the
glsl-out-int-only-functions
branch
from
2fdc50b to
850cb13
Compare
|
Can we add a test for this? |
@teoxoy done |
teoxoy
reviewed
Jun 13, 2022
teoxoy
reviewed
Jun 13, 2022
teoxoy
reviewed
Jun 13, 2022
teoxoy
reviewed
Jun 13, 2022
|
Behavior looks good; just a few things that I think would make the code easier to read. |
Some functions like abs only accept signed integers while naga's IR accepts both signed and unsigned integers, this wasn't accounted for in the glsl backend causing it to produce code that wouldn't type check. This commit addresses it by performing casts from uint to int of the function argument and then back from int to uint for the function return.
JCapucho
force-pushed
the
glsl-out-int-only-functions
branch
from
c470489 to
2cd5157
Compare
|
Thanks @teoxoy, could you please re-review? |
teoxoy
approved these changes
Jun 14, 2022
|
Thanks, @jimblandy; not sure what happened there; I didn't mean to review 4 times 😅 |
jimblandy
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions like abs only accept signed integers while naga's IR
accepts both signed and unsigned integers, this wasn't accounted for in
the glsl backend causing it to produce code that wouldn't type check.
This commit addresses it by performing casts from uint to int of the
function argument and then back from int to uint for the function
return.
closes #1968
Edit: found some problems that need to be fixed firstEdit2: Good to go now