Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize TrackerSet memory allocation #1411

Closed
kvark opened this issue May 27, 2021 · 1 comment
Closed

Optimize TrackerSet memory allocation #1411

kvark opened this issue May 27, 2021 · 1 comment
Labels
area: performance How fast things go help required We need community help to make this happen. type: enhancement New feature or request

Comments

@kvark
Copy link
Member

kvark commented May 27, 2021

Is your feature request related to a problem? Please describe.
See profile in https://share.firefox.dev/3oYh7DG
We are spending significant time merging and extending the trackers.

Describe the solution you'd like
Not completely sure. I'm not seeing an obvious way to do less merging in general.
But we can be better at re-using the tracker memory.

Describe alternatives you've considered
keep all the pass trackers separately, only merging at finish() or submit()

Additional context
Shows up in Gecko performance profiles
@kvark kvark added type: enhancement New feature or request help required We need community help to make this happen. area: performance How fast things go labels May 27, 2021
@kvark kvark mentioned this issue May 28, 2021
Closed
@cwfitzgerald
Copy link
Member

Fixed by #2662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: performance How fast things go help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @cwfitzgerald