Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify when missing texture format is a downlevel restriction #2837

Closed
kpreid opened this issue Jul 2, 2022 · 1 comment
Closed

Specify when missing texture format is a downlevel restriction #2837

kpreid opened this issue Jul 2, 2022 · 1 comment
Labels
area: validation Issues related to validation, diagnostics, and error handling good first issue Good for newcomers help required We need community help to make this happen. type: enhancement New feature or request

Comments

@kpreid
Copy link
Contributor

kpreid commented Jul 2, 2022

Is your feature request related to a problem? Please describe.
wgpu started supporting software rendering and as a result I got this error from my tests running on headless CI with the llvmpipe software renderer:

wgpu error: Validation Error
Caused by:
    In Device::create_texture
      note: label = `EverythingRenderer::linear_scene_texture`
    Texture usages RENDER_ATTACHMENT are not allowed on a texture of type Rgba16Float

This is a downlevel restriction (not-WEBGPU_TEXTURE_FORMAT_SUPPORT) but the error message doesn't say it is, unlike others.

Describe the solution you'd like

Make this error message specify that this is a downlevel issue. This should be possible by, at CreateTextureError::InvalidFormatUsages error printing time, checking the combination requested against the WebGPU specification's required support.
@cwfitzgerald cwfitzgerald added type: enhancement New feature or request help required We need community help to make this happen. good first issue Good for newcomers area: validation Issues related to validation, diagnostics, and error handling labels Jul 3, 2022
@Seamooo Seamooo mentioned this issue Jul 15, 2022
Merged
3 tasks
@teoxoy
Copy link
Member

teoxoy commented Dec 5, 2022

Was fixed by #2886

@teoxoy teoxoy closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: validation Issues related to validation, diagnostics, and error handling good first issue Good for newcomers help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kpreid @cwfitzgerald @teoxoy