Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving web-sys dependency from wgpu-core to wgpu #2989

Open
jimblandy opened this issue Aug 26, 2022 · 2 comments
Open

Consider moving web-sys dependency from wgpu-core to wgpu #2989

jimblandy opened this issue Aug 26, 2022 · 2 comments
Labels
area: infrastructure Testing, building, coordinating issues type: enhancement New feature or request

Comments

@jimblandy
Copy link
Member

Firefox uses wgpu-core, but not wgpu. #2603 added web-sys as a dependency of wgpu-core. Firefox requires that all dependencies be vetted for security, so we would very much like to avoid taking on new dependencies unless absolutely necessary.

I haven't looked at how web-sys is being used at all, and don't have any background. I'm just filing this as a reminder to look into whether it can be conveniently hoisted up a level at some point.

@jimblandy
Copy link
Member Author

jimblandy commented Aug 26, 2022

You might wonder why cargo vet (the tool Firefox is using to track these audits) doesn't just ignore wasm32 dependencies, since we don't ship Firefox as a web page. It turns out that Firefox already compiles some of its C++ components to Wasm just for the sandboxing properties. It wouldn't be surprising if it did the same with Rust at some point in the future. So we can't use "Firefox never runs wasm32 targets" as a simplifying assumption.

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request area: infrastructure Testing, building, coordinating issues labels Aug 29, 2022
@cwfitzgerald
Copy link
Member

I think it could be possible to add a webgl feature to wgc so firefox doesn't see the web-sys dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Testing, building, coordinating issues type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants