Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero_init_workgroup_mem fails in some configurations #3492

Closed
nical opened this issue Feb 16, 2023 · 4 comments
Closed

zero_init_workgroup_mem fails in some configurations #3492

nical opened this issue Feb 16, 2023 · 4 comments
Labels
type: bug Something isn't working

Comments

@nical
Copy link
Contributor

nical commented Feb 16, 2023

Description
A clear and concise description of what the bug is.

On some platforms cargo nextest run fails in zero_init_workgroup_mem.

For example on a Mac M1 max:

thread 'shader::zero_init_workgroup_mem::zero_init_workgroup_mem' panicked at 'Zero-initialization of workgroup memory failed (81% of disptaches failed).', wgpu/tests/shader/zero_init_workgroup_mem.rs:175:5

Repro steps

run cargo nextest run.

Platform

@teoxoy teoxoy added the type: bug Something isn't working label Feb 16, 2023
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Feb 16, 2023
@teoxoy
Copy link
Member

teoxoy commented Feb 21, 2023

@Elabajaba we think we fixed this issue in gfx-rs/naga#2259 (#3512).
Can you confirm that on your Windows + DXC setup it now succeeds?

@nical
Copy link
Contributor Author

nical commented Feb 21, 2023

The mac M1 issue is fixed.

@Elabajaba
Copy link
Contributor

Can you confirm that on your Windows + DXC setup it now succeeds?

DX12 now passes all the tests with both FXC and DXC. (apart from the 1 skipped test)

@cwfitzgerald
Copy link
Member

Sounds like this has been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants