Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VertexFormat documentation uses GLSL instead of WGSL types #3990

Closed
ScanMountGoat opened this issue Jul 29, 2023 · 1 comment · Fixed by #4035
Closed

VertexFormat documentation uses GLSL instead of WGSL types #3990

ScanMountGoat opened this issue Jul 29, 2023 · 1 comment · Fixed by #4035
Labels
area: documentation Documentation for crate items, public or private help required We need community help to make this happen.

Comments

@ScanMountGoat
Copy link
Contributor

ScanMountGoat commented Jul 29, 2023 •
edited
Loading

The current documentation uses GLSL types like float and ivec4 instead of WGSL types like f32 or vec4<i32>. This is related to #2849. This should be an easy fix, but I'm not sure how to handle double precision types. It doesn't look like double precision is mentioned anywhere in the WGSL spec other than literals.

https://www.w3.org/TR/webgpu/#enumdef-gpuvertexformat
@Wumpf Wumpf added help required We need community help to make this happen. area: documentation Documentation for crate items, public or private labels Jul 30, 2023
@Wumpf
Copy link
Member

Wumpf commented Jul 30, 2023

regarding double, let's just pretend it's called f64. It's very likely that in the future there's going to be official wgsl extensions with that, see #4410

@ScanMountGoat ScanMountGoat mentioned this issue Aug 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: documentation Documentation for crate items, public or private help required We need community help to make this happen.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use WGSL for VertexFormat example types ScanMountGoat/wgpu
2 participants
@Wumpf @ScanMountGoat