Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict_extension option for SPIR-V frontend #6507

Open
davnotdev opened this issue Nov 8, 2024 · 1 comment
Open

Add strict_extension option for SPIR-V frontend #6507

davnotdev opened this issue Nov 8, 2024 · 1 comment
Labels
area: naga front-end lang: SPIR-V Vulkan's Shading Language naga Shader Translator type: enhancement New feature or request

Comments

@davnotdev
Copy link

Is your feature request related to a problem? Please describe.
I am trying to convert a SPIR-V shader that uses a dynamic sampler array to wgsl.
However, the OpExtension "SPV_EXT_descriptor_indexing" instruction is not supported.

Describe the solution you'd like
There could be a flag similar to strict_capabilities called strict_extensions which could throw a warning for unsupported extensions. Or there could be some other flag to only allow certain extensions.

Describe alternatives you've considered
My currently solution is to remove the SPV_EXT_descriptor_indexing extension. Although this new shader does succeed when passed through naga, it does not pass spirv-val.

The disassembly of the shader in question

@davnotdev davnotdev changed the title Add naga :: front :: spv::Options::strict_extension Add strict_extension option for SPIR-V frontend Nov 8, 2024
@davnotdev
Copy link
Author

davnotdev commented Nov 8, 2024

strict_extension would imply that by default, ALL extensions would pass whether they are supported or not. Perhaps something like allow_all_extensions would be less confusing?

@teoxoy teoxoy added type: enhancement New feature or request naga Shader Translator lang: SPIR-V Vulkan's Shading Language area: naga front-end labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: naga front-end lang: SPIR-V Vulkan's Shading Language naga Shader Translator type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants