Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo move to MSRV 1.85 breaks rust-gpu #7409

Closed
LegNeato opened this issue Mar 24, 2025 · 6 comments · Fixed by #7425
Closed

Repo move to MSRV 1.85 breaks rust-gpu #7409

LegNeato opened this issue Mar 24, 2025 · 6 comments · Fixed by #7425

Comments

@LegNeato
Copy link
Contributor

Description
A recent changed bumped MSRV to 1.85 (#7218), even though >1.83 was all that was required (according to that PR).

Going to 1.85 breaks rust-gpu as we are on nightly-2024-11-22 (~1.84). We have a ton of compiler work to port forward on our end (Rust-GPU/rust-gpu#182), so it won't happen before the next wgpu release. This means people using rust-gpu will not be able to use wgpu / will have to pin to an old version.

We'd love it if you could stay with 1.84 until you absolutely need 1.85.
@LegNeato
Copy link
Contributor Author

LegNeato commented Mar 24, 2025 •
edited
Loading

Note that if rust-gpu folks are stuck on older version of wgpu they won't get my fix from 10cd1cc. Without that fix certain spirv fails in Naga. In one of our test projects porting shadertoys, 5/27 shaders hit that naga bug.

@LegNeato LegNeato mentioned this issue Mar 24, 2025
Draft
@ErichDonGubler
Copy link
Member

@cwfitzgerald: I don't think we have anything that's reliant on Rust 1.85 specifically? In which case, downgrading doesn't sound too bad.

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Mar 24, 2025 •
edited
Loading

Yeah I don't think there's anything, we haven't turned on the 2024 edition, I don't think. Let's do it.

@cwfitzgerald
Copy link
Member

Could you also include a link to where we can see rust-gpu's current toolchain version, so we don't have this issue again.

@LegNeato
Copy link
Contributor Author

Awesome! Here is the toolchain file with the version: https://github.com/Rust-GPU/rust-gpu/blob/main/rust-toolchain.toml

@LegNeato
Copy link
Contributor Author

(we're hoping to track nightly, and we were there during 1.84, but then got hit with some major rustc changes that slowed us down from forward-porting).

LegNeato added a commit to LegNeato/wgpu that referenced this issue Mar 25, 2025
@LegNeato
Reduce repo MSRV from 1.85 to 1.84
6d1916a 
Fixes gfx-rs#7409
@LegNeato LegNeato mentioned this issue Mar 25, 2025
Merged
LegNeato added a commit to LegNeato/wgpu that referenced this issue Mar 25, 2025
@LegNeato
Reduce repo MSRV from 1.85 to 1.84
d85bb38 
Fixes gfx-rs#7409
LegNeato added a commit to LegNeato/wgpu that referenced this issue Mar 26, 2025
@LegNeato
Reduce repo MSRV from 1.85 to 1.84
46599bf 
Fixes gfx-rs#7409
@github-project-automation github-project-automation bot moved this from Todo to Done in WebGPU for Firefox Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce repo MSRV from 1.85 to 1.84 LegNeato/wgpu
3 participants
@LegNeato @ErichDonGubler @cwfitzgerald