Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisper.wasm : update Emscripten bridge to provide text segments and token data to the JS layer #585

Open
DavidGOrtega opened this issue Mar 8, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DavidGOrtega
Copy link

DavidGOrtega commented Mar 8, 2023

While Im testing the code I have seen that full_default do not return the data, just only logs it.
To be able to retrieve them I have override the print and printErr handlers to extract the data and then apply clunky regexes.
Could not be awesome if we could gather the output instead of the error code? Or both?

@ggerganov ggerganov added the question Further information is requested label Mar 8, 2023
@ggerganov
Copy link
Owner

The C++/JS bridge in emscripten.cpp has to be extended to provide the output to the JS layer.
It's not very difficult to achieve, but I keep postponing it since it is low priority. I think it should be an easy task for people looking to contribute to the project

@DavidGOrtega
Copy link
Author

worth a good first issue?

@ggerganov ggerganov changed the title whisper.wasm : How to get the outputs whisper.wasm : update Emscripten bridge to provide text segments and token data to the JS layer Mar 8, 2023
@ggerganov ggerganov added enhancement New feature or request good first issue Good for newcomers and removed question Further information is requested labels Mar 8, 2023
@DavidGOrtega
Copy link
Author

@ggerganov I can take it

@laurensV
Copy link

This would be a great feature to have..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants