Skip to content

Commit 4da69d1

Browse files
authored
Revert "llama : add Falcon3 support (#10864)" (#10876)
This reverts commit 382bc7f.
1 parent d62b532 commit 4da69d1

File tree

3 files changed

+0
-25
lines changed

3 files changed

+0
-25
lines changed

convert_hf_to_gguf.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,6 @@ def get_vocab_base(self) -> tuple[list[str], list[int], str]:
525525
else:
526526
token: str = reverse_vocab[i]
527527
if token in added_vocab:
528-
# We need to manually encode and decode the added tokens in case special characters
529-
# used for `\n` / `\t` have been manually added in the added tokens
530-
token = tokenizer.decode(tokenizer.encode(token))
531528
if tokenizer.added_tokens_decoder[i].special or self.does_token_look_special(token):
532529
toktypes.append(gguf.TokenType.CONTROL)
533530
else:
@@ -574,9 +571,6 @@ def get_vocab_base_pre(self, tokenizer) -> str:
574571
if chkhsh == "8aeee3860c56296a157a1fe2fad249ec40aa59b1bb5709f4ade11c4e6fe652ed":
575572
# ref: https://huggingface.co/tiiuae/falcon-7b
576573
res = "falcon"
577-
if chkhsh == "9d032fcbd5501f4a38150912590928bfb36091efb5df11b8e2124b0390e3fb1e":
578-
# ref: https://huggingface.co/tiiuae/Falcon3-7B-Base
579-
res = "falcon3"
580574
if chkhsh == "0876d13b50744004aa9aeae05e7b0647eac9d801b5ba4668afc01e709c15e19f":
581575
# ref: https://huggingface.co/BAAI/bge-small-en-v1.5
582576
res = "bert-bge"

convert_hf_to_gguf_update.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ class TOKENIZER_TYPE(IntEnum):
7272
{"name": "deepseek-coder", "tokt": TOKENIZER_TYPE.BPE, "repo": "https://huggingface.co/deepseek-ai/deepseek-coder-6.7b-base", },
7373
{"name": "falcon", "tokt": TOKENIZER_TYPE.BPE, "repo": "https://huggingface.co/tiiuae/falcon-7b", },
7474
{"name": "bert-bge", "tokt": TOKENIZER_TYPE.WPM, "repo": "https://huggingface.co/BAAI/bge-small-en-v1.5", },
75-
{"name": "falcon3", "tokt": TOKENIZER_TYPE.BPE, "repo": "https://huggingface.co/tiiuae/Falcon3-7B-Base", },
7675
{"name": "bert-bge-large", "tokt": TOKENIZER_TYPE.BPE, "repo": "https://huggingface.co/BAAI/bge-large-zh-v1.5", },
7776
{"name": "mpt", "tokt": TOKENIZER_TYPE.BPE, "repo": "https://huggingface.co/mosaicml/mpt-7b", },
7877
{"name": "starcoder", "tokt": TOKENIZER_TYPE.BPE, "repo": "https://huggingface.co/bigcode/starcoder2-3b", },

src/llama.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1612,7 +1612,6 @@ enum llm_chat_template {
16121612
LLM_CHAT_TEMPLATE_MISTRAL_V3_TEKKEN,
16131613
LLM_CHAT_TEMPLATE_MISTRAL_V7,
16141614
LLM_CHAT_TEMPLATE_PHI_3,
1615-
LLM_CHAT_TEMPLATE_FALCON_3,
16161615
LLM_CHAT_TEMPLATE_ZEPHYR,
16171616
LLM_CHAT_TEMPLATE_MONARCH,
16181617
LLM_CHAT_TEMPLATE_GEMMA,
@@ -1645,7 +1644,6 @@ static const std::map<std::string, llm_chat_template> LLM_CHAT_TEMPLATES = {
16451644
{ "mistral-v3-tekken", LLM_CHAT_TEMPLATE_MISTRAL_V3_TEKKEN },
16461645
{ "mistral-v7", LLM_CHAT_TEMPLATE_MISTRAL_V7 },
16471646
{ "phi3", LLM_CHAT_TEMPLATE_PHI_3 },
1648-
{ "falcon3", LLM_CHAT_TEMPLATE_FALCON_3 },
16491647
{ "zephyr", LLM_CHAT_TEMPLATE_ZEPHYR },
16501648
{ "monarch", LLM_CHAT_TEMPLATE_MONARCH },
16511649
{ "gemma", LLM_CHAT_TEMPLATE_GEMMA },
@@ -6475,11 +6473,6 @@ static void llm_load_vocab(
64756473
} else if (
64766474
tokenizer_pre == "falcon") {
64776475
vocab.type_pre = LLAMA_VOCAB_PRE_TYPE_FALCON;
6478-
} else if (
6479-
tokenizer_pre == "falcon3") {
6480-
vocab.type_pre = LLAMA_VOCAB_PRE_TYPE_LLAMA3;
6481-
vocab.tokenizer_ignore_merges = true;
6482-
vocab.tokenizer_add_bos = true;
64836476
} else if (
64846477
tokenizer_pre == "mpt") {
64856478
vocab.type_pre = LLAMA_VOCAB_PRE_TYPE_MPT;
@@ -22226,8 +22219,6 @@ static llm_chat_template llama_chat_detect_template(const std::string & tmpl) {
2222622219
}
2222722220
} else if (tmpl_contains("<|assistant|>") && tmpl_contains("<|end|>")) {
2222822221
return LLM_CHAT_TEMPLATE_PHI_3;
22229-
} else if (tmpl_contains("<|assistant|>") && tmpl_contains("<|user|>")) {
22230-
return LLM_CHAT_TEMPLATE_FALCON_3;
2223122222
} else if (tmpl_contains("<|user|>") && tmpl_contains("<|endoftext|>")) {
2223222223
return LLM_CHAT_TEMPLATE_ZEPHYR;
2223322224
} else if (tmpl_contains("bos_token + message['role']")) {
@@ -22380,15 +22371,6 @@ static int32_t llama_chat_apply_template_internal(
2238022371
if (add_ass) {
2238122372
ss << "<|assistant|>\n";
2238222373
}
22383-
} else if (tmpl == LLM_CHAT_TEMPLATE_FALCON_3) {
22384-
// Falcon 3
22385-
for (auto message : chat) {
22386-
std::string role(message->role);
22387-
ss << "<|" << role << "|>\n" << message->content << "\n";
22388-
}
22389-
if (add_ass) {
22390-
ss << "<|assistant|>\n";
22391-
}
2239222374
} else if (tmpl == LLM_CHAT_TEMPLATE_ZEPHYR) {
2239322375
// zephyr template
2239422376
for (auto message : chat) {

0 commit comments

Comments
 (0)