speculative : fix seg fault in certain cases (#12454)

ggerganov · web-flow · commit c6af2161b200 · 2025-03-18T19:35:11.000+02:00
diff --git a/examples/speculative/speculative.cpp b/examples/speculative/speculative.cpp
@@ -331,11 +331,11 @@ int main(int argc, char ** argv) {
                         }
 
                         active_seqs.erase(s);
-                        for(int i = 0; i < n_seq_dft; i++) {
+                        for (int i = 0; i < n_seq_dft; i++) {
                             if (i == s) {
                                 continue;
                             }
-                            if (drafts[i].tokens[i_dft] == drafts[s].tokens[i_dft]) {
+                            if (drafts[i].active && drafts[i].tokens[i_dft] == drafts[s].tokens[i_dft]) {
                                 // synchronize active status for sequences with the same drafted token
                                 drafts[i].active = drafts[i].active && accept;
                                 if (!drafts[i].active) {

Original file line number	Diff line number	Diff line change
`@@ -331,11 +331,11 @@ int main(int argc, char ** argv) {`
`331`	`331`	`}`
`332`	`332`
`333`	`333`	`active_seqs.erase(s);`
`334`		`- for(int i = 0; i < n_seq_dft; i++) {`
	`334`	`+ for (int i = 0; i < n_seq_dft; i++) {`
`335`	`335`	`if (i == s) {`
`336`	`336`	`continue;`
`337`	`337`	`}`
`338`		`- if (drafts[i].tokens[i_dft] == drafts[s].tokens[i_dft]) {`
	`338`	`+ if (drafts[i].active && drafts[i].tokens[i_dft] == drafts[s].tokens[i_dft]) {`
`339`	`339`	`// synchronize active status for sequences with the same drafted token`
`340`	`340`	`drafts[i].active = drafts[i].active && accept;`
`341`	`341`	`if (!drafts[i].active) {`