Skip to content

Commit e0a686b

Browse files
committed
rm unused or duplicated code, rename as review comment
1 parent bff9eb8 commit e0a686b

File tree

1 file changed

+15
-18
lines changed

1 file changed

+15
-18
lines changed

ggml-sycl.cpp

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15575,11 +15575,11 @@ __dpct_inline__ static void k_copy_dst_from_contiguous(
1557515575
static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1557615576
const ggml_tensor *src1,
1557715577
ggml_tensor *dst) try {
15578-
GGML_ASSERT(src0->backend != GGML_BACKEND_TYPE_GPU_SPLIT &&
15579-
"mul_mat_id does not support split buffers");
15578+
GGML_ASSERT(!ggml_backend_buffer_is_sycl_split(src0->buffer) && "mul_mat_id does not support split buffers");
15579+
1558015580
const ggml_tensor *ids = dst->src[2];
1558115581
GGML_TENSOR_BINARY_OP_LOCALS
15582-
GGML_ASSERT(!ggml_backend_buffer_is_sycl_split(src0->buffer) && "mul_mat_id does not support split buffers");
15582+
1558315583
const dpct::queue_ptr stream = g_syclStreams[g_main_device][0];
1558415584

1558515585
const int64_t n_as = ne02;
@@ -15698,13 +15698,13 @@ static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1569815698
sycl::range<3> block_dims(1, 1, std::min((unsigned int)ne10, 768u));
1569915699
sycl::range<3> grid_dims(1, n_ids, ids->ne[1]);
1570015700
stream->submit([&](sycl::handler &cgh) {
15701-
sycl::local_accessor<int, 0> src1_row_acc_ct1(cgh);
15701+
sycl::local_accessor<int, 0> src1_row_acc(cgh);
1570215702

15703-
char *__restrict src1_contiguous_get_ct1 =
15703+
char *__restrict src1_contiguous_get =
1570415704
src1_contiguous.get();
15705-
int *__restrict dev_cur_src1_row_get_ct2 =
15705+
int *__restrict dev_cur_src1_row_get =
1570615706
dev_cur_src1_row.get();
15707-
mmid_row_mapping *__restrict dev_row_mapping_get_ct3 =
15707+
mmid_row_mapping *__restrict dev_row_mapping_get =
1570815708
dev_row_mapping.get();
1570915709
size_t ids_nb_ct6 = ids->nb[1];
1571015710
size_t ids_nb_ct7 = ids->nb[0];
@@ -15713,11 +15713,11 @@ static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1571315713
sycl::nd_range<3>(grid_dims * block_dims, block_dims),
1571415714
[=](sycl::nd_item<3> item_ct1) {
1571515715
k_copy_src1_to_contiguous(
15716-
src1_original, src1_contiguous_get_ct1,
15717-
dev_cur_src1_row_get_ct2,
15718-
dev_row_mapping_get_ct3, ids_dev, i02,
15716+
src1_original, src1_contiguous_get,
15717+
dev_cur_src1_row_get,
15718+
dev_row_mapping_get, ids_dev, i02,
1571915719
ids_nb_ct6, ids_nb_ct7, ne11, ne10, nb11, nb12,
15720-
item_ct1, src1_row_acc_ct1);
15720+
item_ct1, src1_row_acc);
1572115721
});
1572215722
});
1572315723
}
@@ -15743,25 +15743,22 @@ static void ggml_sycl_mul_mat_id(const ggml_tensor *src0,
1574315743
sycl::range<3> block_dims(1, 1, std::min((unsigned int)ne0, 768u));
1574415744
sycl::range<3> grid_dims(1, 1, num_src1_rows);
1574515745
stream->submit([&](sycl::handler &cgh) {
15746-
const char *__restrict dst_contiguous_get_ct1 =
15746+
const char *__restrict dst_contiguous_get =
1574715747
dst_contiguous.get();
15748-
const mmid_row_mapping *__restrict dev_row_mapping_get_ct2 =
15748+
const mmid_row_mapping *__restrict dev_row_mapping_get =
1574915749
dev_row_mapping.get();
1575015750

1575115751
cgh.parallel_for(
1575215752
sycl::nd_range<3>(grid_dims * block_dims, block_dims),
1575315753
[=](sycl::nd_item<3> item_ct1) {
1575415754
k_copy_dst_from_contiguous(dst_original,
15755-
dst_contiguous_get_ct1,
15756-
dev_row_mapping_get_ct2,
15755+
dst_contiguous_get,
15756+
dev_row_mapping_get,
1575715757
ne0, nb1, nb2, item_ct1);
1575815758
});
1575915759
});
1576015760
}
1576115761
}
15762-
if (dst->backend == GGML_BACKEND_TYPE_CPU) {
15763-
SYCL_CHECK(CHECK_TRY_ERROR(stream->wait()));
15764-
}
1576515762
}
1576615763
}
1576715764
catch (sycl::exception const &exc) {

0 commit comments

Comments
 (0)