Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be possible to set the RNG seed after restoring state. #1182

Closed
asgeir opened this issue Apr 25, 2023 · 2 comments
Closed

It should be possible to set the RNG seed after restoring state. #1182

asgeir opened this issue Apr 25, 2023 · 2 comments

Comments

@asgeir
Copy link
Contributor

asgeir commented Apr 25, 2023

The new llama_copy_state_data, llama_set_state_data API preserves the RNG seed without providing an option of changing the seed.

It would be useful to have some llama_set_rng_seed function to have an option of setting the seed after restoring the state.
rng_seed.patch
@xaedes
Copy link
Collaborator

xaedes commented Apr 25, 2023

Personally I think that makes sense.
When you have a working version you could make a pull request.

@asgeir
Copy link
Contributor Author

asgeir commented Apr 25, 2023

I've created a pull request. #1184

@asgeir asgeir closed this as completed Apr 26, 2023
@Bearsaerker Bearsaerker mentioned this issue Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asgeir @xaedes