Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEGV on moderately complex grammar #7810

Open
hoehrmann opened this issue Jun 7, 2024 · 1 comment
Open

SIGSEGV on moderately complex grammar #7810

hoehrmann opened this issue Jun 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@hoehrmann
Copy link

hoehrmann commented Jun 7, 2024

(In #7572 @HanClinto wrote:)

@HanClinto Further down in the gist https://gist.github.com/hoehrmann/f234c1156ee5ef7b24cb589c14aaefda?permalink_comment_id=5070397#gistcomment-5070397 is a variant where I removed the redundant empty string alternative. llamap.cpp then goes into SIGSEGV after a couple of lines (or pretty much immediately if you change the root to the <middle> section of the grammar) asking a model to write an Internet-Draft in xml2rfc format.

Confirmed, thank you! I ran the following command:

./main -mu https://huggingface.co/NousResearch/Hermes-2-Pro-Mistral-7B-GGUF/resolve/main/Hermes-2-Pro-Mistral-7B.Q4_K_M.gguf \
    --grammar-file ./grammars/issue7572.gbnf \
    -p "Please generate an Internet-Draft in xml2rfc format." \
    --seed 12345

And it crashed after:

 Please generate an Internet-Draft in xml2rfc format.<rfc>
<front><title>Test</title><author><organization>IETF</organization><address><email>jdoe@example.com</email></address></author><date>
</date>
</front><middle>
<section>
<./test_7572.sh: line 4: 72743 Segmentation fault: 11  ./main -mu https://huggingface.co/NousResearch/Hermes-2-Pro-Mistral-7B-GGUF/resolve/main/Hermes-2-Pro-Mistral-7B.Q4_K_M.gguf --grammar-file ./grammars/issue7572.gbnf -p "Please generate an Internet-Draft in xml2rfc format." --seed 12345
@HanClinto HanClinto self-assigned this Jun 10, 2024
@github-actions github-actions bot added the stale label Jul 11, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

@HanClinto HanClinto reopened this Jul 25, 2024
@slaren slaren added bug Something isn't working and removed stale labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants