Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated agreement file #34

Open
kowloon12 opened this issue Jul 6, 2017 · 2 comments
Open

outdated agreement file #34

kowloon12 opened this issue Jul 6, 2017 · 2 comments

Comments

@kowloon12
Copy link

286c286
<     NEW_REG='{"resource":"new-reg","contact":["mailto:'"$ACCOUNT_EMAIL"'"],"agreement":"https://letsencrypt.org/documents/LE-SA-v1.0.1-July-27-2015.pdf"}'
---
>     NEW_REG='{"resource":"new-reg","contact":["mailto:'"$ACCOUNT_EMAIL"'"],"agreement":"https://letsencrypt.org/documents/LE-SA-v1.1.1-August-1-2016.pdf"}'
@cpu
Copy link

cpu commented Jul 6, 2017

I believe this is a duplicate of: #32

And three! unmerged pull request to patch over it exist: #27, #26, #30

As I commented on #30 having a hardcoded agreement URL is the wrong way to write an ACME account registration flow. Unfortunately it seems this repo is unmaintained :'(

@bruncsak
Copy link

Hi @cpu , I am not really writing this to you rather to everybody else reading that issue.
I agree, this repo seemingly isn't maintained any more. On the other hand I am trying to fully maintain my fork, https://github.com/bruncsak/letsencrypt.sh where I fixed the "outdated agreement file" issue among lot of other issues. That issue is not simply solved by updating the hard-coded version, rather the URL of the up-to-date version of the agreement dynamically looked up from the directory.

So I suggest everybody to start working directly with my version. I enabled the "issues" section in my fork of repository to allow feedback for it. Do not hesitate to open issues there if you have problem with my version, otherwise do not forget to star my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants