Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RowSpan should work with Excel Export and merge cells #1819

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 24, 2025

also improve Text Export (csv/txt) but technically speaking the only thing we do in that export type is to change cell to empty string when a span is found because a we merge any cells in csv so the best we can do is to empty the cells... in other words, Excel Export has a much better UX because we do have access cell merge in Excel

image

Copy link

stackblitz bot commented Jan 24, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.5%. Comparing base (70e7222) to head (3fe0c08).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1819     +/-   ##
========================================
+ Coverage    99.5%   99.5%   +0.1%     
========================================
  Files         187     187             
  Lines       34442   34467     +25     
  Branches    10191   10202     +11     
========================================
+ Hits        34259   34284     +25     
  Misses        183     183             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 8b0d4a3 into master Jan 24, 2025
8 checks passed
@ghiscoding ghiscoding deleted the bugfix/export-rowspan branch January 24, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant