Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to control cl-ana.table-viewing gnuplot behavior? #26

Open
kat-co opened this issue May 6, 2019 · 1 comment
Open

How to control cl-ana.table-viewing gnuplot behavior? #26

kat-co opened this issue May 6, 2019 · 1 comment

Comments

@kat-co
Copy link
Contributor

kat-co commented May 6, 2019

I am unfamiliar with gnuplot. I was able to get plots by specifying the :file keyword in the cl-ana.plotting package, but the cl-ana.table-viewing package doesn't allow users to pass this through. So:

  1. Does gnuplot somehow display graphs from within the terminal? I am running these commands from within SLIME from withing graphical emacs. Without an output file, I simply get back a T, so I think something is happening, but I'm unsure what.
  2. Do we want the table-viewing package to pass through plotting keywords? This seems like a high amount of coupling. Instead, perhaps we could pass in a closure in which is responsible for the plotting, and takes a limited set of arguments. This way, the caller may create the closure in the stack-frame above, utilizing all the plotting arguments they need, and then pass it into table-viewing functions. This keeps table-viewing and plotting decoupled, but still working together.
@ghollisjr
Copy link
Owner

Ah this is actually due to me not completing the table-viewing package. The way I've typically handled drawing options is by allowing three arguments "page-options", "plot-options", and "line-options" or something along those lines so there is detailed control over plotting.

As far as coupling goes, I think it is acceptable because the idea of table-viewing is to allow easy drawing of information from tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants