Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor command "context" system & Support User Apps #200

Open
2 tasks
ghostdevv opened this issue Apr 21, 2024 · 3 comments
Open
2 tasks

Refactor command "context" system & Support User Apps #200

ghostdevv opened this issue Apr 21, 2024 · 3 comments
Labels
needs shaping More information needed / Decision needs making
Milestone

Comments

@ghostdevv
Copy link
Owner

ghostdevv commented Apr 21, 2024

  • Move the context settings into a nested object
  • breaking: Make global the default
@ghostdevv ghostdevv added the enhancement New feature or request label Apr 21, 2024
@ghostdevv
Copy link
Owner Author

ghostdevv commented Apr 21, 2024

Ideas for the nested object setting

context?: {
	/** @default true */
	global?: boolean;
	
	/** @default false */
	dm?: boolean;

	/** @default false */
	user?: boolean;

	/** @default [] */
	guilds?: string[] // todo should this be able to accept an async function? if so when should that run
}

Another idea from old issue:

environments: ['global', 'dm', 'user']

@ghostdevv

This comment was marked as resolved.

@ghostdevv ghostdevv added this to the v1 milestone May 11, 2024
@ghostdevv ghostdevv changed the title Support user apps Move Contexts & Support User Apps Nov 10, 2024
@ghostdevv ghostdevv changed the title Move Contexts & Support User Apps Refactor command "context" system & Support User Apps Nov 10, 2024
@ghostdevv
Copy link
Owner Author

To move forward I need to consider:

  • What contexts Discord "defaults" to?
  • Whether requiring you to be explicit is ideal (to reduce potential confusion)?
  • Are any contexts mutually exclusive?
  • Should we allow overwriting the defaults on a global level? (maybe should require users do with a transform plugin, if those are re-added)

@ghostdevv ghostdevv added needs shaping More information needed / Decision needs making and removed enhancement New feature or request labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs shaping More information needed / Decision needs making
Projects
None yet
Development

No branches or pull requests

1 participant