Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some websites just don't load #311

Closed
sentialx opened this issue Sep 2, 2019 · 3 comments · Fixed by #312
Closed

Some websites just don't load #311

sentialx opened this issue Sep 2, 2019 · 3 comments · Fixed by #312

Comments

@sentialx
Copy link
Contributor

sentialx commented Sep 2, 2019 •
edited
Loading

Hi, I noticed (and also others noticed, see wexond/browser-base#320) that some websites don't load. I've discovered only 2 websites which don't work:

After disabling adblock, these two are loading properly.
@sentialx sentialx changed the title Some websites just doesn't load Some websites just don't load Sep 2, 2019
@remusao remusao mentioned this issue Sep 2, 2019
Merged
@remusao
Copy link
Collaborator

remusao commented Sep 2, 2019

Hi @sentialx,

I could reproduce locally and pushed a fix there #312. The issue is that some filters can apply on the main document request, which then prevents the website from loading completely. I've added a check to prevent that from happening.

I will release a minor release today.

@sentialx
Copy link
Contributor Author

sentialx commented Sep 2, 2019

Thanks!

@remusao
Copy link
Collaborator

remusao commented Sep 2, 2019

No worries. Release v1.0.2 fixing this issue is already available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not block main document requests remusao/adblocker
2 participants
@remusao @sentialx