Fix UnicodeEncodeError with non ASCII paths on Windows (Python 2)

[BoboTiG]

OS: Windows.
Python version impacted: 2.

When dealing with non ASCII chars in the path (let's say the username is Mickaël), we are blocked on an unicode error:

======================================================================
FAIL: test_open_files (proc=psutil.Process(pid=2548, name='explorer.exe', started='09:02:04'))
----------------------------------------------------------------------
Traceback (most recent call last):
  File "psutil\tests\test_contracts.py", line 331, in test_fetch_all
	ret = attr(*args, **kwargs)
  File "psutil\__init__.py", line 1133, in open_files
	return self._proc.open_files()
  File "psutil\_pswindows.py", line 635, in wrapper
	return fun(self, *args, **kwargs)
  File "psutil\_pswindows.py", line 882, in open_files
	_file = convert_dos_path(_file)
  File "psutil\_compat.py", line 140, in wrapper
	result = user_function(*args, **kwds)
  File "psutil\_pswindows.py", line 189, in convert_dos_path
	driveletter = cext.win32_QueryDosDevice(rawdrive)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xeb' in position 32: ordinal not in range(128)

Here, rawdrive = '\BaseNamedObjects\C::Users:Mickaël:AppData:Local:Microsoft:Windows:Explorer:thumbcache_32.db!dfMaintainer'.

[BoboTiG]

It still breaks some tests. I do not know if there is a possibile simple fix. Perhaps the good move is to use Python 3.

[BoboTiG]

I close the issue, I will switch to Python 3 :)

[giampaolo]

No please leave it open. Python 2 will still be supported for a long time.

[giampaolo]

I'm having troubles reproducing this. I tried:

# -*- coding: utf-8 -*- 

import psutil

s = '\BaseNamedObjects\C::Users:Mickaël:AppData:Local:Microsoft:Windows:Explorer:thumbcache_32.db!dfMaintainer'

print(repr(psutil._psplatform.cext.win32_QueryDosDevice(s)))

...but it succeeds returning an empty string.

[gliptak]

With Python 2.7 EOL, maybe this can be closed

https://www.python.org/downloads/

 Python version Maintenance status First released End of support Release schedule
    2.7 end-of-life 2010-07-03 2020-01-01 PEP 373

[giampaolo]

Python 2 downloads are still around 30% and it's not gonna disappear anytime soon:
https://pypistats.org/packages/psutil

[BoboTiG]

Can we close this issue @giampaolo?

[giampaolo]

Yes, I recently dropped 2.7 support so this is not necessary anymore. =)