fix most warnings and test failures on win32 #579
Conversation
mindw
force-pushed
the
fix_win32_failures
branch
from
838a611 to
3dc838f
Compare
|
This is truly awesome, thanks! I've been wanting to fix these warnings for a long time but never managed to get around them. There's still one last warning popping up:
Do you think you can do anything about that? |
| @@ -601,7 +601,7 @@ psutil_proc_memory_info(PyObject *self, PyObject *args) | |||
| return NULL; | |||
| } | |||
|
|
|||
| if (! GetProcessMemoryInfo(hProcess, &cnt, sizeof(cnt)) ) { | |||
| if (! GetProcessMemoryInfo(hProcess, (PPROCESS_MEMORY_COUNTERS)&cnt, sizeof(cnt)) ) { | |||
There was a problem hiding this comment.
This line len exceeds 80 chars. Something like this should work:
if (! GetProcessMemoryInfo(hProcess, (PPROCESS_MEMORY_COUNTERS)&cnt,
sizeof(cnt)))
{
3dc838f to
25f87a8
Compare
mindw
force-pushed
the
fix_win32_failures
branch
from
bbcc7bd to
2f7a403
Compare
|
Fixed open_files for PID>=64K. |
|
Cool! What's PrintError? I see you defined it but apparently you never use it. |
fix most warnings and test failures on win32
|
PrintError = ExtremlyComplexAndScaryMsStyle( strerror); It should replace GetError() calls in the commented out debug prints. Please note that TestDualProcessImplementation::proc_io_counters still fails for me. I'll try and solve this sometime in the future ... |
also silence most compilation warnings