-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inet_ntop to support Windows XP #616
Conversation
Sorry for getting at this so late. I don't like having a new file for this. Do you think it's possible to do this in |
It's possible but _psutil_windows.c seems to be focused on adding actual functionality (_psutil_functions) where as this is just adding a missing library function for Windows XP. It'd be a lot easier to drop in the future (once XP support is removed) if it's kept in a separate file. |
I see your point. OK then. Can you please update HISTORY and CREDITS as well? Then we can merge. |
0eecbf0
to
7f06236
Compare
Done and rebased. |
Implement inet_ntop to support Windows XP
Merged. Thanks. |
After this change I get 2 errors on Windows 7:
|
Fixes the issue I found @ #597 (comment)