Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 1.x.x overwrite in config-controller #626

Closed
Tracked by #600
kopiczko opened this issue Dec 9, 2021 · 3 comments
Closed
Tracked by #600

Allow 1.x.x overwrite in config-controller #626

kopiczko opened this issue Dec 9, 2021 · 3 comments
Labels

Comments

@kopiczko
Copy link

kopiczko commented Dec 9, 2021

Capo MCs are dynamic and we use giantswarm/config "auto" branches (in format INSTALLATION_auto_config) to not pollute main with commit flood.

But that doesn't work with release apps that have installation specific overwrites as by default config-controller takes latest 1.x.x. We can't use config.giantswarm.io/version in Chart.yaml because that would work with only single installation.

Possible solution here is adding a flag to make config-controller replace 1.x.x with custom ref.

@kopiczko kopiczko changed the title Allow 1.x.x overwrite config-controller Allow 1.x.x overwrite in config-controller Dec 9, 2021
@kubasobon
Copy link

config-controller will die in the future, so my approach is add anything to your heart's content.

@tfussell
Copy link

tfussell commented Jan 4, 2022

I think this issue can be closed. We don't use any MC apps managed by release-operator in OpenStack v20.0.0-alpha1 release https://github.com/giantswarm/releases/blob/master/openstack/v20.0.0-alpha1/release.yaml#L28-L31 so there are no Config CRs involved.

@cornelius-keller
Copy link
Contributor

Closing. Reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants