Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the author list display #80

Closed
only1chunts opened this issue Nov 7, 2016 · 2 comments
Closed

change the author list display #80

only1chunts opened this issue Nov 7, 2016 · 2 comments

Comments

@only1chunts
Copy link
Member

only1chunts commented Nov 7, 2016

This issue will actually be fixed by completing #81
This should also be considered whilst looking at issue #82
At least 2 authors have said the format of the author list on the webpage is inconsistent with how they would expect to see names displayed, i.e. using comma's instead of periods between initials. check how GigaScience journal displays them and match it.

@only1chunts
Copy link
Member Author

The citations are listed in GigaScience papers as . e.g Hebsgaard MB, Gilbert MTP, Arneborg J

rija referenced this issue in rija/gigadb-website Jan 19, 2018
rija referenced this issue in rija/gigadb-website Feb 2, 2018
It's best practice to use "composer install" insstad of keeeping the composer vendorised subtree of dependencies.
rija referenced this issue in rija/gigadb-website Feb 2, 2018
downgraded PHPUnit to 4.1.1, so it work with the Yii Framework (even 4.3.* doesn't work with Yii 1.1).
Switched to minimum-stability: stable, so I can remove the @stable suffixes
add @dev suffix to mink-wunit-driver as that's the only branch avaiable for that package.
Removed google api client as it's already in Gigadb codebase.

Because of the PHPUNit downgraded, cannot use namespace when using PHPUNit Assert
(PHPUNit\Framework\Assert had to be replaced by PHPUnit_Framework_Assert)

Controlled which Behat hooks get run with which scenario using tags on features and on hooks
so that for example oauth revokation hook are only actioned in affilate login scenario

Addded a scenario to ensure the test environment is loaded up with all the test data in the author name display and name display preview tests.

Updated one sql test data script to drop the not null constraint on the affiliation column of the gigadb_user table.

Updated the test runner so it run all the acceptance tests and unit tests.
rija referenced this issue in rija/gigadb-website Feb 2, 2018
…cumentation

After all tests have run, the previous state of the database is restored.
This is done in the test runner now as it is a concern that overarch all tests.
Updating the TESTING docs with info on running unit tests and the above database setup.
rija referenced this issue in rija/gigadb-website Feb 6, 2018
Fixed syntax of pg_dump to ensure the initial state of database is saved and restored.
increased sleep time after terminating pg backend processes
Made the test runner logs visible in protected/runtime/
Moved the printCurrentUrl inside the try{} block as it blows up when a step fails and no web session has been started yet(with visit)
rija referenced this issue in rija/gigadb-website Feb 7, 2018
…e deterministic

By default CDbFixtureManager.php loads the fixtures using readdir() which returns list files in the order in which they are stored by the filesystem. It "seems" than that order vary from system to system resulting in the following error:

CDbException: CDbCommand failed to execute the SQL statement: SQLSTATE[23503]: Foreign key violation: 7 ERROR:  insert or update on table "dataset_author" violates foreign key constraint "dataset_author_author_id_fkey"
DETAIL:  Key (author_id)=(1) is not present in table "author".

because the join table fixture is loaded before the data table.

I've created an init.php file in the fixtures directory to customise the fixture loading behaviour, in this case, ensuring the fixtures are loaded  in the order that won't violate the foreign key constraint.
@rija rija removed the Rija label Mar 11, 2024
@rija
Copy link
Contributor

rija commented Mar 11, 2024

closing as done and merged 6 years ago

@rija rija closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants