Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When spawning singlefile from within a docker container, it will leave defunct chrome processes behind. #26

Open
felixkosmalla opened this issue Apr 3, 2023 · 0 comments

Comments

@felixkosmalla
Copy link

felixkosmalla commented Apr 3, 2023

This is not a problem when doing single-shot executions with a docker container that starts, runs singlefile, and stops again. However, when running a small flask server as a frontend to singlefile which spawns singlefile via subprocess, it will leave a couple of defunct chrome processes behind.

It seems this is a general problem with puppeteer and does not originate from singelfile itself. To overcome this issue, tini can be used as a prefix when calling singlefile which makes sure to terminate all child processes:

tini -s /usr/src/app/node_modules/single-file-cli/single-file ...

Leaving this here for documentation purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant