IPv6 Support?

[adam-vest]

Hello! I'm just curios if IPv6 is currently supported, or if not, if it's on the roadmap? I was just trying some brute-force means like:

ip_address: [::]

But maaspower doesn't seems to appreciate that.

[gilesknap]

@adam-vest I've never done anything special to support IPV6 and to be honest have never got involved with it before. So Unless Flask supports it by default then no.

I had a quick Google and the implication is that it does support v6.

What error are you getting?

[adam-vest]

Looks like a validation error:

Failed validating 'type' in schema['properties']['ip_address']:
    {'description': 'IP address to listen on',
     'type': <JsonType.STRING: 'string'>}

On instance['ip_address']:
    ['::']
Traceback (most recent call last):
  File "/usr/local/bin/maaspower", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.9/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/typer/main.py", line 500, in wrapper
    return callback(**use_params)  # type: ignore
  File "/usr/local/lib/python3.9/site-packages/maaspower/__main__.py", line 62, in run
    jsonschema.validate(config_dict, schema_config)
  File "/usr/local/lib/python3.9/site-packages/jsonschema/validators.py", line 1022, in validate
    raise error
jsonschema.exceptions.ValidationError: ['::'] is not of type <JsonType.STRING: 'string'>

If I try wrapping it in quotes - ip_address: "[::]" - error changes a little (single or double quotes doesn't appear to matter):

 * Serving Flask app 'maaspower' (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
Traceback (most recent call last):
  File "/usr/local/bin/maaspower", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.9/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/typer/main.py", line 500, in wrapper
    return callback(**use_params)  # type: ignore
  File "/usr/local/lib/python3.9/site-packages/maaspower/__main__.py", line 66, in run
    run_web_hook(maas_globals.maas_config)
  File "/usr/local/lib/python3.9/site-packages/maaspower/webhook.py", line 57, in run_web_hook
    app.run(host=c.ip_address, port=c.port)
  File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 920, in run
    run_simple(t.cast(str, host), port, self, **options)
  File "/usr/local/lib/python3.9/site-packages/werkzeug/serving.py", line 1017, in run_simple
    inner()
  File "/usr/local/lib/python3.9/site-packages/werkzeug/serving.py", line 957, in inner
    srv = make_server(
  File "/usr/local/lib/python3.9/site-packages/werkzeug/serving.py", line 789, in make_server
    return ThreadedWSGIServer(
  File "/usr/local/lib/python3.9/site-packages/werkzeug/serving.py", line 693, in __init__
    super().__init__(server_address, handler)  # type: ignore
  File "/usr/local/lib/python3.9/socketserver.py", line 452, in __init__
    self.server_bind()
  File "/usr/local/lib/python3.9/http/server.py", line 138, in server_bind
    socketserver.TCPServer.server_bind(self)
  File "/usr/local/lib/python3.9/socketserver.py", line 466, in server_bind
    self.socket.bind(self.server_address)
socket.gaierror: [Errno -2] Name or service not known

[gilesknap]

OK that makes lot's of sense now.

I think you might get it to work simply by putting quotes around your address.

[adam-vest]

Hey there! Thanks for the reply, and sorry for the delay - finally making it out of the weeds of the holidays heh. I tried wrapping the address in quotes a few different ways:

ip_address: "[::]"

and

ip_address: ["::"]

The former gives the "Name or service not known" error. The latter gives the "not of type" validation error.

Knowing that the backend uses flask, I did some quick research on the topic and discovered that the brackets were actually the source of the problem. This seems to work as expected!

ip_address: "::"

Thank for all your help!

[gilesknap]

Awesome. Thanks for letting me know.