Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Does this Action work with v2 GitHub Actions #6

Closed
pruett opened this issue Sep 12, 2019 · 3 comments
Closed

[Question] Does this Action work with v2 GitHub Actions #6

pruett opened this issue Sep 12, 2019 · 3 comments

Comments

@pruett
Copy link

pruett commented Sep 12, 2019

I've been looking to trigger a new Check Run from a GitHub Action and have looked at your repository as an example.

First, this doesn't seem to work (no additional Check Run) is spawned in my PR. I'm using GitHub Actions v2 and curious if you're aware of this or have any additional information.

For example...

.github/workflows/main.yml

name: checks

on:
  pull_request:
    branches:
      - master
  push:
    branches:
      - master

jobs:
  checks:
    runs-on: ubuntu-latest
    name: check
    steps:
      - name: Checkout
        uses: actions/checkout@v1

      - run: npm install

      - name: ESLint checks
         uses: gimenete/eslint-action@1.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Your action runs and I see the output of:

2 error(s), 0 warning(s) found
 ##[error]Docker run failed with exit code 78

But no additional Check Run was created like in your screenshot.

Do you know if this is a GitHub issue (Actions being in Beta, etc.) or is there something more obvious I'm missing?

Thanks.

@exoRift
Copy link

exoRift commented Sep 12, 2019

I messaged the dev on Twitter. It doesn't work with YAML at the moment, but he's working on it

@pruett
Copy link
Author

pruett commented Sep 16, 2019

Thanks @mets11rap, funny enough, so did I. Closing this down as it appears to be a known issue by GitHub that is being addressed.

@pruett pruett closed this as completed Sep 16, 2019
@gimenete
Copy link
Owner

gimenete commented Sep 19, 2019

@pruett here there's a user that is working on a eslint Action for GitHub Actions v2 based on this repo: actions/toolkit#133 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants