Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests to a (non-published) sub-crate #187

Open
fitzgen opened this issue Nov 15, 2019 · 0 comments
Open

Move tests to a (non-published) sub-crate #187

fitzgen opened this issue Nov 15, 2019 · 0 comments
Labels
E-easy good-first-contribution

Comments

@fitzgen
Copy link
Member

fitzgen commented Nov 15, 2019

And move the build.rs to that sub-crate, since it is only used for generating tests.

This should help cargo better-parallelize builds of crate graphs that include cpp_demangle.

This requires somethign like:

  • Create a new cpp_demangle_tests crate located at crates/tests
  • Move all the tests into there
  • Move build.rs to that crate
  • Update CONTRIBUTING.md to mention cargo test --all for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy good-first-contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen