Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LineProgram] Don't make LineEncoding configurable #468

Closed
bjorn3 opened this issue Jan 14, 2020 · 1 comment · Fixed by #476
Closed

[LineProgram] Don't make LineEncoding configurable #468

bjorn3 opened this issue Jan 14, 2020 · 1 comment · Fixed by #476

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Jan 14, 2020

This would likely make it possible for LLVM to optimize a division away which accounts for ~30% of the time in generate_row. I don't see much use for it anyway.

self.row.address_offset % u64::from(self.line_encoding.minimum_instruction_length),

and

/ u64::from(self.line_encoding.minimum_instruction_length);

@philipc
Copy link
Collaborator

philipc commented Jan 14, 2020

Alternatively, we could do something like 35c7750 and rely on branch prediction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants