Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop go1.8/go1.9 support #1912

Closed
dmarkham opened this issue May 22, 2019 · 3 comments · Fixed by #1933
Closed

Drop go1.8/go1.9 support #1912

dmarkham opened this issue May 22, 2019 · 3 comments · Fixed by #1933
Milestone
1.5

Comments

@dmarkham
Copy link
Contributor

Drop go1.8/go1.9 support to stay somewhat close to go's supported versions and keep people from having to do workarounds to stay compatible with older versions of go.
@dmarkham
Copy link
Contributor Author

dmarkham commented May 22, 2019 •
edited
Loading

@appleboy @thinkerou I think this should be a gin 1.5 milestone, thoughts?

@thinkerou
Copy link
Member

thinkerou commented May 22, 2019 •
edited
Loading

I agree @dmarkham
gin1.5 support go1.10,1.11,1.12,1.13
gin1.6 support go1.11,1.12,1.13,1.14

and gin not use only the feature of go1.8 or go1.9 now.

@dmarkham dmarkham mentioned this issue Jun 6, 2019
Merged
@thinkerou thinkerou added this to the 1.5 milestone Jun 7, 2019
@TonyPythoneer
Copy link

@thinkerou Please follow @dmarkham ‘s PR.
The issue has PR can get resolved. thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

Drop Support for go1.8 and go1.9 dmarkham/gin
3 participants
@dmarkham @thinkerou @TonyPythoneer