gin context with tracing not work

[pepea23]

when implementing use otel tracing like this

and apply to router like "router.POST("/v4/*xxxx", gatewayPostHandler, WithTracer())"

then tried to get a trace I found that gin context does not save trace id and span id it empty so how to reproduce the problem?

handler function

trace_id and span_id is empty

GetTraceIds function

Environment

• go version: 1.22.4
• gin version (or commit ref): github.com/gin-gonic/gin v1.10.0

[FarmerChillax]

problem locating the hasRequestContext function return False：

gin/context.go

Line 1240 in 9c081de

func (c *Context) hasRequestContext() bool {

It seems that the problem is caused by the ContextWithFallback field, but I am not sure what this field does.

Solution:

// ...
app := gin.Default()
app.ContextWithFallback = true
// ...

[JimChenWYU]

router.POST("/v4/*xxxx", gatewayPostHandler, WithTracer())

replace by

router.POST("/v4/*xxxx", WithTracer(), gatewayPostHandler)

can it work ?

[mgerasimchuk]

Faced a similar issue too..

Using tracing middleware instead of a handlers chain will help you

[FarmerChillax]

This issue is same with #4074

Add example in gin-gonic/examples#171, hope this helps for you @mgerasimchuk @pepea23 @JimChenWYU

[FarmerChillax]

It seems that the problem is caused by the ContextWithFallback field, but I am not sure what this field does.

Do I need to open a new issue to track this? @appleboy

[appleboy]

@FarmerChillax Yes. Please open the new issue.