@@ -162,15 +162,15 @@ TYPED_TEST(ResidualNorm, WaitsTillResidualGoal)
162
162
.residual_norm (res_norm.get ())
163
163
.check (RelativeStoppingId, true , &stop_status, &one_changed));
164
164
165
- res_norm->at (0 ) = r<TypeParam>::value * 1.1 * res_norm ->at (0 );
165
+ res_norm->at (0 ) = r<TypeParam>::value * 1.1 * rhs_norm ->at (0 );
166
166
ASSERT_FALSE (
167
167
rhs_criterion->update ()
168
168
.residual_norm (res_norm.get ())
169
169
.check (RelativeStoppingId, true , &stop_status, &one_changed));
170
170
ASSERT_EQ (stop_status.get_data ()[0 ].has_converged (), false );
171
171
ASSERT_EQ (one_changed, false );
172
172
173
- res_norm->at (0 ) = r<TypeParam>::value * 0.9 * res_norm ->at (0 );
173
+ res_norm->at (0 ) = r<TypeParam>::value * 0.9 * rhs_norm ->at (0 );
174
174
ASSERT_TRUE (
175
175
rhs_criterion->update ()
176
176
.residual_norm (res_norm.get ())
@@ -180,6 +180,7 @@ TYPED_TEST(ResidualNorm, WaitsTillResidualGoal)
180
180
}
181
181
{
182
182
auto res_norm = gko::initialize<NormVector>({100.0 }, this ->exec_ );
183
+ auto init_res_val = res_norm->at (0 , 0 );
183
184
constexpr gko::uint8 RelativeStoppingId{1 };
184
185
bool one_changed{};
185
186
gko::Array<gko::stopping_status> stop_status (this ->exec_ , 1 );
@@ -190,15 +191,15 @@ TYPED_TEST(ResidualNorm, WaitsTillResidualGoal)
190
191
.residual_norm (res_norm.get ())
191
192
.check (RelativeStoppingId, true , &stop_status, &one_changed));
192
193
193
- res_norm->at (0 ) = r<TypeParam>::value * 1.1 * res_norm-> at ( 0 ) ;
194
+ res_norm->at (0 ) = r<TypeParam>::value * 1.1 * init_res_val ;
194
195
ASSERT_FALSE (
195
196
rel_criterion->update ()
196
197
.residual_norm (res_norm.get ())
197
198
.check (RelativeStoppingId, true , &stop_status, &one_changed));
198
199
ASSERT_EQ (stop_status.get_data ()[0 ].has_converged (), false );
199
200
ASSERT_EQ (one_changed, false );
200
201
201
- res_norm->at (0 ) = r<TypeParam>::value * 0.9 * res_norm-> at ( 0 ) ;
202
+ res_norm->at (0 ) = r<TypeParam>::value * 0.9 * init_res_val ;
202
203
ASSERT_TRUE (
203
204
rel_criterion->update ()
204
205
.residual_norm (res_norm.get ())
@@ -590,6 +591,7 @@ TYPED_TEST(ResidualNormReduction, WaitsTillResidualGoal)
590
591
auto initial_res = gko::initialize<Mtx>({100.0 }, this ->exec_ );
591
592
std::shared_ptr<gko::LinOp> rhs = gko::initialize<Mtx>({10.0 }, this ->exec_ );
592
593
auto res_norm = gko::initialize<NormVector>({100.0 }, this ->exec_ );
594
+ auto init_res_val = res_norm->at (0 , 0 );
593
595
auto criterion =
594
596
this ->factory_ ->generate (nullptr , rhs, nullptr , initial_res.get ());
595
597
bool one_changed{};
@@ -602,15 +604,15 @@ TYPED_TEST(ResidualNormReduction, WaitsTillResidualGoal)
602
604
.residual_norm (res_norm.get ())
603
605
.check (RelativeStoppingId, true , &stop_status, &one_changed));
604
606
605
- res_norm->at (0 ) = r<TypeParam>::value * 1.1 * res_norm-> at ( 0 ) ;
607
+ res_norm->at (0 ) = r<TypeParam>::value * 1.1 * init_res_val ;
606
608
ASSERT_FALSE (
607
609
criterion->update ()
608
610
.residual_norm (res_norm.get ())
609
611
.check (RelativeStoppingId, true , &stop_status, &one_changed));
610
612
ASSERT_EQ (stop_status.get_data ()[0 ].has_converged (), false );
611
613
ASSERT_EQ (one_changed, false );
612
614
613
- res_norm->at (0 ) = r<TypeParam>::value * 0.9 * res_norm-> at ( 0 ) ;
615
+ res_norm->at (0 ) = r<TypeParam>::value * 0.9 * init_res_val ;
614
616
ASSERT_TRUE (
615
617
criterion->update ()
616
618
.residual_norm (res_norm.get ())
0 commit comments