Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Structures): Nouveau modèle SiaeActivity #1261

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Jun 10, 2024

Quoi ?

Nouveau modèle SiaeActivity

  • rattaché à une siae
  • avec 1 ou plusieurs sectors qui font partie d'un même sector_group
  • un presta_type, geo_range & geo_range_custom_distance

J'ai aussi intégré dans l'admin (SiaeActivity, et dans Siae)

Pourquoi ?

Permettre aux structures de mieux décrire leur activité (offres, secteurs...)

@raphodn raphodn requested a review from madjid-asa June 10, 2024 15:10
@raphodn raphodn force-pushed the raphodn/siae-activity-model branch from 6f556ab to a7f0feb Compare June 10, 2024 15:12
null=True,
db_index=True,
)
geo_range = models.CharField(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me demande si on devrait pas plutôt utilisé les perimeters, si on met le geo_range, ça veut dire qu'il faudrait ajouter une adresse, des structures peuvent avoir des activité à différents lieux d'intervention ^^

Copy link
Contributor Author

@raphodn raphodn Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

  • on limitera seulement sur les périmètres CITY ?
  • il faudra peut-être rajouter ce périmètre au niveau du modèle Siae, ou trouver un moyen simple de l'obtenir à partir de l'adresse

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi tu veux limiter aux City ?
Au pire de toute façon on pourra moduler :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes en effet, à voir quand on se servira de ces données pour la recherche, si on a besoin de restreindre le formulaire ou pas

Base automatically changed from raphodn/siae-model-history to master June 12, 2024 09:34
@raphodn raphodn force-pushed the raphodn/siae-activity-model branch from e9f516b to c3b6220 Compare June 12, 2024 09:35
Copy link
Contributor

@madjid-asa madjid-asa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

null=True,
db_index=True,
)
geo_range = models.CharField(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi tu veux limiter aux City ?
Au pire de toute façon on pourra moduler :)

@raphodn raphodn changed the title feat(Structures): nouveau modèle SiaeActivity feat(Structures): Nouveau modèle SiaeActivity Jun 13, 2024
@raphodn raphodn merged commit e458851 into master Jun 13, 2024
9 checks passed
@raphodn raphodn deleted the raphodn/siae-activity-model branch June 13, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants