feat: Ajout d'attributs de contact pour les acheteurs inscrits #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienReuiller
requested changes
Oct 21, 2024
chloend
force-pushed
the
chloend/contact-attributes
branch
from
dbd947e
to
9a7d97c
Compare
…and un user et tender sont créés
chloend
force-pushed
the
chloend/contact-attributes
branch
from
9a7d97c
to
ab337a1
Compare
madjid-asa
approved these changes
Nov 7, 2024
madjid-asa
reviewed
Nov 7, 2024
chloend
force-pushed
the
chloend/contact-attributes
branch
from
770b422
to
285b8c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Ajout de trois attributs lors de la création de contact dans la liste #10 (Acheteurs inscrits) de Brevo :
Pourquoi ?
Pour segmenter les envois d'email et ne pas multiplier les listes sur Brevo.
Comment ?
En ajoutant un argument
tender_iddans la méthodeadd_to_contact_listdéfinie dans emails.py. Cette dernière est appelée dans les trois méthodes de création de Tender (done,perform_createetcsrf_failure) afin de récupérer l'id du tender qui permettra d'associer les informations du tender à l'utilisateur de type "acheteur".Captures d'écran (optionnel)
Autre (optionnel)
Tests :
test_user_with_valid_api_key_can_create_tenderpour que les assertEqual du nombre de User passent.